Update CLI tests to test terminal commands #2473
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tory to account for dir already existing
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CLI e2e tests to properly test terminal commands across both Unix-like systems and Windows platforms. It also refactors CopilotCLIImageSupport to use direct Node.js fs APIs instead of IWorkspaceService.
Key changes:
- Removes platform-specific test skip for Windows in terminal command tests
- Updates test to use platform-appropriate commands (
Get-Locationfor Windows,pwdfor Unix) - Adds
IChatDelegationSummaryServiceto test service registration - Refactors
CopilotCLIImageSupportto removeIWorkspaceServicedependency
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/e2e/cli.stest.ts | Adds service registration for IChatDelegationSummaryService, enables terminal command test on Windows, and updates test to use platform-specific commands with case-insensitive permission matching |
| src/extension/agents/copilotcli/node/copilotCLIImageSupport.ts | Removes IWorkspaceService dependency and replaces filesystem operations with direct Node.js fs module calls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.