Fix NESProvider in chat-lib #2570
Merged
+44
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a breaking change in the NESProvider used by chat-lib by refactoring the UndesiredModelsManager to support optional dependency injection. The issue occurred when IVSCodeExtensionContext was added as a direct dependency to InlineEditsModelService, causing library consumers without VS Code extension context to fail.
Key changes:
- Extracted
IUndesiredModelsManagerinterface to enable dependency injection and alternative implementations - Moved
UndesiredModels.Managerfrom node implementation to common interface layer for reusability - Added
NullUndesiredModelsManageras a no-op implementation for library consumers - Made
undesiredModelsManageran optional parameter inINESProviderOptionsfor chat-lib users
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/platform/inlineEdits/node/inlineEditsModelService.ts |
Removed direct IVSCodeExtensionContext dependency and UndesiredModels namespace; replaced with injected IUndesiredModelsManager service |
src/platform/inlineEdits/common/inlineEditsModelService.ts |
Added IUndesiredModelsManager interface, moved UndesiredModels.Manager implementation here, and added NullUndesiredModelsManager null implementation |
src/lib/node/chatLibMain.ts |
Added optional undesiredModelsManager parameter to INESProviderOptions and registered service with fallback to null implementation |
src/extension/extension/vscode/services.ts |
Registered UndesiredModels.Manager as the implementation of IUndesiredModelsManager for the VS Code extension |
The refactoring successfully decouples the platform service from VS Code-specific APIs while maintaining functionality for extension consumers and enabling library consumers to provide their own implementations or use the default no-op behavior.
jeffreyhunter77
force-pushed
the
jeffreyhunter77/broken-nes-provider
branch
from
b257d47 to
ae98bf1
Compare
…VSCodeExtensionContext
jeffreyhunter77
force-pushed
the
jeffreyhunter77/broken-nes-provider
branch
from
ae98bf1 to
01741b5
Compare
hediet
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition of the
IVSCodeExtensionContextdependency inInlineEditsModelServicecausesNESProviderin chat-lib to break (and publishing to fail) because of the missing dependency that shows up in a failing test:Can we do this to get
NESProviderworking again (and with the option for library users to provide an implementation if they choose)?