Speculative requests for chat-lib #2591
Merged
+44
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for speculative requests in chat-lib's inline completions by introducing a mechanism to notify when a completion is shown to the user. Previously, speculative requests couldn't be initiated because chat-lib had no way to indicate when completions were displayed.
Key Changes:
- Added
inlineCompletionShown()method toIInlineCompletionsProviderinterface to signal when a completion is displayed - Implemented the method in
InlineCompletionsProviderclass to trigger pending speculative requests via the cache
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/lib/node/chatLibMain.ts | Added inlineCompletionShown method to interface and implementation to trigger speculative requests when completions are shown |
| chat-lib/test/getInlineCompletions.spec.ts | Added test coverage for speculative request functionality and refactored test setup to track fetch counts |
jeffreyhunter77
force-pushed
the
jeffreyhunter77/chat-lib-speculative
branch
from
b96a2a6 to
90bc6ba
Compare
chrmarti
approved these changes
Dec 16, 2025
hediet
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speculative requests for inline completions are only initiated once the completion is shown to the user.
Currently there is no way in chat-lib to indicate that a completion has been shown, which means no speculative requests are issued. This adds a method for indicating a completion has been shown, which in turn sends any pending speculative request.