Fix: Variable name can start with a digit#43
Open
OverflowCat wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix: Variable name can start with a digit#43OverflowCat wants to merge 1 commit intomicrosoft:mainfrom
OverflowCat wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Co-authored-by: yzqzss <30341059+yzqzss@users.noreply.github.com>
Author
|
@microsoft-github-policy-service agree |
romainmenke
approved these changes
Jun 17, 2025
Contributor
romainmenke
left a comment
There was a problem hiding this comment.
Thank you for the detailed description and fix!
LGTM
|
@microsoft-github-policy-service agree |
clover-yan
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the spec, an
<ident-token>cannot start with a digit. However, for variables that begin with a double-hyphen--, the name following it CAN start with a digit.For example,
--7-grid-columns-minus-last-gap(found by @yzqzss in GitHub's landing page) is a completely valid variable name.Current grammar does not properly highlight it:
This change to the lexical grammar was made in 2014, although they didn't mention it clearly:
The old definition: