Fix unpredictable markdown link text when copying permalink from gutter #8252
+26
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right-clicking the gutter to copy a permalink as markdown produced unpredictable link text because
getMarkdownLinkText()used the editor selection, which doesn't change on gutter clicks.Changes
PermalinkInfoto include the range used for permalink generationgetMarkdownLinkText()to accept and prioritize the permalink's range over current selectioncreateSinglePermalink()andcreateSingleGitHubLink()to propagate range informationBehavior
Before: Link text could be from previous selection, blank, or arbitrary depending on cursor position
After: Link text extracted from the line the permalink references
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.