Exclude pending reviews from "Show Changes Since Last Review" #8264
+21
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Show Changes Since Last Review" was treating pending (not-yet-submitted) reviews as the reference point, causing the diff to reset when new commits arrived during an active review.
Changes
GraphQL Query (
queriesShared.gql):viewerLatestReviewtoreviews(last: 1, author: $author, states: [APPROVED, CHANGES_REQUESTED, COMMENTED, DISMISSED])PENDINGstateImplementation (
pullRequestModel.ts):authorparameter (current user login) to query variablesreviews.nodes[0]instead ofviewerLatestReviewTypes & Tests (
graphql.ts,latestReviewCommitBuilder.ts):LatestReviewCommitResponseinterface to reflect new query structureThe fix ensures only submitted reviews are considered when computing diffs since last review.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
update.code.visualstudio.com/opt/hostedtoolcache/node/20.19.6/x64/bin/node node ./out/src/test/runTests.js --grep getViewerLatestReviewCommit -git�� it s-errors/type.d.ts ndor/bin/sh it s/sourcemap-segm-c /opt/hostedtoolcgit diff --cached --name-only grep -l submodules | head -n 10 ./node_modules/memfs/lib/node/types/promises.d.ts tnet/tools/git it les/@jridgewell/-ne tnet/tools/grep grep(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.