Watch and remove file attachments that are deleted #283387
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements automatic removal of file attachments when the underlying files are deleted from the file system. It adds a file system change listener to the ChatAttachmentModel that monitors for file deletion events and removes corresponding attachments from the model.
Key Changes:
- Added file system change listener to detect deleted file attachments
- Automatically removes deleted files from the attachment list via the existing
updateContextmethod
| return; | ||
| } | ||
|
|
||
| const watcher = this.fileService.createWatcher(uri, { recursive: false, excludes: [] }); |
There was a problem hiding this comment.
Is there a cost with creating many watchers? In a dumb case when I have tons of files attached, is it bad to create 20 of these and have them around for a long time?
There was a problem hiding this comment.
The comment on IFileService says to prefer correlated watchers - otherwise events get fired to every watcher.
Looking through the watchers code it seems that the cost of creating a watcher is a couple of entries in hash tables, so I think it's reasonable.
Perhaps @bpasero can provide more specific guidance.
Fixes #282900