fix: correct the separator for uvx packages #283572 #283584
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the version separator used when installing Python-based MCP servers through uvx. The code was incorrectly using pip's == separator instead of uvx's @ separator, causing MCP servers to fail to start.
Key Changes:
- Updated the version separator for Python registry type from
==to@to match uvx's requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #283572
uvx uses an
@for separating package and version. This is different to pip which uses==https://docs.astral.sh/uv/concepts/tools/#tool-versions
Currently the code that installs MCP servers into VSCode from a registry uses
==as a separator which causes MCP servers to fail to start.This PR updates that separator to the correct
@as currently it looks like UVX is the only supported python runtimehttps://github.com/microsoft/vscode/blob/main/src/vs/platform/mcp/common/mcpManagementService.ts#L171