Fix ContextView absolute positioning when container lacks position: relative #283599
+20
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hover tooltips (e.g., Copy button in diagnostic hovers) were positioned incorrectly when the container element didn't have
position: relative. The offset matched exactly the distance from the container's nearest positioned ancestor.Root cause:
doLayout()assumed the container was the CSS containing block for absolute positioning. Forposition: absolute, the containing block is actually the nearest positioned ancestor (viaoffsetParent), not necessarily the container.Fix: Use
offsetParentto find the actual containing block:Changes:
src/vs/base/browser/ui/contextview/contextview.ts: UpdateddoLayout()to useoffsetParentfor position offset calculation in absolute positioning modeOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.