Skip to content

Conversation

@dmitrivMS
Copy link
Contributor

Fixes #15604

Added a toggle to file and text search quick access to disable exclusions/ignore files. The toggle uses same icon as in Search View and is bound to Ctrl+Dot shortcut.

Copilot AI review requested due to automatic review settings December 15, 2025 20:54
@dmitrivMS dmitrivMS added search Search widget and operation issues quick-open Quick-open issues (search, commands) labels Dec 15, 2025
@dmitrivMS dmitrivMS self-assigned this Dec 15, 2025
@dmitrivMS dmitrivMS enabled auto-merge December 15, 2025 20:54
@vs-code-engineering
Copy link

vs-code-engineering bot commented Dec 15, 2025

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@bpasero

Matched files:

  • src/vs/base/browser/ui/toggle/toggle.ts

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a toggle control to quick access (file and text search) that allows users to enable or disable exclude settings and ignore files during searches. The toggle uses the same icon (Codicon.exclude) as the Search View and is accessible via Ctrl+Dot (Cmd+Period on Mac) when quick access is open.

Key changes:

  • New UseExcludesToggle widget extending base Toggle class with search-specific configuration
  • Integration of toggle into both file search (anythingQuickAccess.ts) and text search (textSearchQuickAccess.ts) quick access providers
  • New reload() method on IQuickPick interface to refresh items without changing the search value
  • Cache key modification to differentiate results based on exclude settings state

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/vs/workbench/contrib/search/browser/useExcludesToggle.ts New toggle widget class and keyboard action registration for toggling excludes/ignore files
src/vs/workbench/contrib/search/browser/anythingQuickAccess.ts Integrates exclude toggle into file search quick access, modifying query options based on toggle state
src/vs/workbench/contrib/search/browser/quickTextSearch/textSearchQuickAccess.ts Integrates exclude toggle into text search quick access, includes typo fix in comment
src/vs/workbench/contrib/search/browser/search.contribution.ts Registers the toggle contributions with the search module
src/vs/workbench/contrib/search/common/constants.ts Adds new command ID for the toggle action
src/vs/base/browser/ui/toggle/toggle.ts Adds new toggle() method to programmatically toggle state
src/vs/platform/quickinput/common/quickInput.ts Adds reload() method to IQuickPick interface
src/vs/platform/quickinput/browser/quickInput.ts Implements reload() method by firing change value event with current value
src/vs/workbench/contrib/search/test/browser/useExcludesToggle.test.ts Unit tests for the new UseExcludesToggle widget
src/vs/platform/quickinput/test/browser/quickinput.test.ts Tests for the new reload() functionality

dmitrivMS and others added 4 commits December 15, 2025 13:17
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@dmitrivMS
Copy link
Contributor Author

To be fair, I think Copilot pulled most changes for me from #281303 which is essentially the same. If we decide to take it, probably best to update that PR and let it go in.

@bpasero bpasero self-requested a review December 16, 2025 05:59
@bpasero
Copy link
Member

bpasero commented Dec 16, 2025

I would like to review and test this change but will probably not get to it until next year.

@dmitrivMS
Copy link
Contributor Author

I would like to review and test this change but will probably not get to it until next year.

We will likely be moving it to the original community PR and you're welcome to look at it there.

@dmitrivMS
Copy link
Contributor Author

@bpasero Closing this one, will continue in #281303 to which I've added you as a reviewer.

@dmitrivMS dmitrivMS closed this Dec 16, 2025
auto-merge was automatically disabled December 16, 2025 19:24

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

quick-open Quick-open issues (search, commands) search Search widget and operation issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simple way to temporarily turn off exclusions for QuickOpen files

3 participants