Add text preformat border high contrast color #283784
Open
+12
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @rzhao271Matched files:
@alexr00Matched files:
@joaomorenoMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new theme color textPreformat.border to enhance the visibility of inline code elements (preformatted text) in high contrast themes. The border is applied consistently across various UI components including chat interfaces, settings editor, release notes, notebook chat, webviews, and walkthrough pages.
Key Changes:
- Adds new
textPreformat.bordercolor definition with high contrast theme support - Applies the border styling consistently across 7 CSS/HTML files
- Updates color values for existing preformat colors in high contrast modes
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/vs/platform/theme/common/colors/baseColors.ts |
Defines new textPreformat.border color and updates high contrast color values for preformat text |
build/lib/stylelint/vscode-known-variables.json |
Registers the new CSS variable for stylelint validation |
src/vs/workbench/contrib/chat/browser/media/chat.css |
Adds border to inline code elements in chat interface |
src/vs/workbench/contrib/chat/browser/chatContentParts/media/chatThinkingContent.css |
Adds border to code elements in chat thinking/reasoning display |
src/vs/workbench/contrib/notebook/browser/media/notebookCellChat.css |
Adds border to code elements in notebook chat interface |
src/vs/workbench/contrib/preferences/browser/media/settingsEditor2.css |
Adds border to code elements in settings descriptions |
src/vs/workbench/contrib/update/browser/releaseNotesEditor.ts |
Adds border to code elements and removes obsolete padding properties (with syntax error) |
src/vs/workbench/contrib/webview/browser/pre/index.html |
Adds border to code elements in webview content |
src/vs/workbench/contrib/welcomeWalkthrough/browser/media/walkThroughPart.css |
Adds border to code elements in walkthrough pages |
aiday-mar
previously approved these changes
Dec 16, 2025
Member
|
@mrleemurray red CI |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
aiday-mar
previously approved these changes
Dec 16, 2025
Contributor
Author
|
@bpasero they are timing out during |
aiday-mar
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new border color for preformatted text segments (i.e.
codeelements) and apply it across various components to enhance visibility in high contrast themes. Adjustments made to ensure consistent styling and improved accessibility.Addresses: #204405