some eligible tweaks #283878
Closed
some eligible tweaks #283878
+216
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for configuring extension-provided tools using short names (e.g., issue_fetch) instead of requiring the full reference name format (e.g., github.vscode-pull-request-github/issue_fetch) in the chat.tools.eligibleForAutoApproval configuration setting. This improvement makes the configuration more user-friendly while maintaining backward compatibility with both full reference names and legacy names.
Key Changes:
- Extended eligibility lookup logic to support short name matching as a fallback
- Ensured full reference names take precedence over short names when both are configured
- Added legacy tool names to the configuration schema enumeration for better validation and IntelliSense support
- Added comprehensive test coverage for the new short name matching behavior
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/browser/languageModelToolsService.ts |
Added short name lookup fallback in isToolEligibleForAutoApproval method, checking the tool's reference name when the full reference name doesn't match in the configuration |
src/vs/workbench/contrib/chat/test/browser/languageModelToolsService.test.ts |
Added 4 new tests covering short name matching, full name matching, precedence rules, and eligibility scenarios for extension-provided tools |
src/vs/workbench/contrib/chat/browser/chat.contribution.ts |
Enhanced configuration schema to include legacy tool reference names with duplicate prevention, improving IntelliSense and validation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.