notebook tests still failing too often #283882
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses flaky notebook smoke tests by skipping three tests that have been failing frequently, as tracked in issue #283857. The approach is consistent with existing test management practices in the smoke test suite where unreliable tests are temporarily disabled while fixes are being developed.
Key Changes:
- Three notebook smoke tests are being skipped: 'inserts/edits code cell', 'moves focus as it inserts/deletes a cell', and 'moves focus in and out of output'
| }); | ||
|
|
||
| it('inserts/edits code cell', async function () { | ||
| it.skip('inserts/edits code cell', async function () { |
There was a problem hiding this comment.
The newly skipped test should include a comment explaining why it's being skipped and referencing the issue. Following the pattern used elsewhere in this file (lines 81, 91) and in other smoke tests, consider adding an inline comment with the issue reference. For example: it.skip('inserts/edits code cell', async function () { // https://github.com/microsoft/vscode/issues/283857
| }); | ||
|
|
||
| it('moves focus as it inserts/deletes a cell', async function () { | ||
| it.skip('moves focus as it inserts/deletes a cell', async function () { |
There was a problem hiding this comment.
The newly skipped test should include a comment explaining why it's being skipped and referencing the issue. Following the pattern used elsewhere in this file (lines 81, 91) and in other smoke tests, consider adding an inline comment with the issue reference. For example: it.skip('moves focus as it inserts/deletes a cell', async function () { // https://github.com/microsoft/vscode/issues/283857
| }); | ||
|
|
||
| it('moves focus in and out of output', async function () { // TODO@rebornix https://github.com/microsoft/vscode/issues/139270 | ||
| it.skip('moves focus in and out of output', async function () { // TODO@rebornix https://github.com/microsoft/vscode/issues/139270 |
There was a problem hiding this comment.
The newly skipped test should include a comment explaining why it's being skipped and referencing the issue. Following the pattern used elsewhere in this file (lines 81, 91) and in other smoke tests, consider adding an inline comment with the issue reference. For example: it.skip('moves focus in and out of output', async function () { // https://github.com/microsoft/vscode/issues/283857 // TODO@rebornix https://github.com/microsoft/vscode/issues/139270
#283857