Update msCompile matcher to handle more cases #283885
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the msCompile problem matcher regex to handle additional diagnostic format variations from MSBuild and C# compilers, fixing issues #274750 and #167454. The changes make the pattern more flexible by supporting optional location information, optional diagnostic codes, subcategories, and leading whitespace.
Key changes:
- Enhanced the
msCompileregex pattern to handle optional components (location, code, subcategory) - Added fallback logic to change problem location kind from
LocationtoFilewhen location info is absent - Added comprehensive test coverage for the new regex capabilities
- Included an unrelated fix for proper disposal of TaskQuickPick instances
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/workbench/contrib/tasks/common/problemMatcher.ts | Updated msCompile regex to make location and code optional, support subcategories, and handle leading whitespace; added logic to fallback to File kind when location is missing |
| src/vs/workbench/contrib/tasks/test/common/problemMatcher.test.ts | Added comprehensive test suite for msCompile matcher covering all new regex capabilities including leading whitespace, optional codes, optional locations, subcategories, and complex scenarios |
| src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts | Added try-finally block to ensure TaskQuickPick is properly disposed after use (unrelated to PR description) |
| const taskQuickPick = this._instantiationService.createInstance(TaskQuickPick); | ||
| try { | ||
| return await taskQuickPick.show(placeHolder, defaultEntry, type, name); | ||
| } finally { | ||
| taskQuickPick.dispose(); | ||
| } |
There was a problem hiding this comment.
This change adds proper disposal of the TaskQuickPick instance, which is good for resource management. However, this change is not mentioned in the PR description and appears unrelated to the msCompile matcher update described in the title and linked issues. Consider creating a separate PR for this fix or updating the PR description to mention this additional improvement.
fixes #274750
fixes #167454
And adds lots of tests