Skip to content

feat: Support limited search for added file #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asmundg wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Support limited search for added file #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55c75da
feat: Support limited search for added file
asmundg May 6, 2022
74f1259
Change files
asmundg May 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions change/workspace-tools-2022-05-06-09-14-39-asmundg-limit-rev-list-search.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "minor",
"comment": "feat: Support limited search for added file",
"packageName": "workspace-tools",
"email": "asgramme@microsoft.com",
"dependentChangeType": "patch",
"date": "2022-05-06T07:14:39.673Z"
}
5 changes: 3 additions & 2 deletions src/git.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,8 +264,9 @@ export function getCurrentHash(cwd: string) {
/**
* Get the commit hash in which the file was first added.
*/
export function getFileAddedHash(filename: string, cwd: string) {
const results = git(["rev-list", "HEAD", filename], { cwd });
export function getFileAddedHash(filename: string, cwd: string, fromRef?: string, toRef?: string) {
Copy link
Member

@ecraig12345 ecraig12345 Jul 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be better to combine these in a single parameter, like range?: { fromRef: string; toRef: string }. That way it's clear that both fromRef and toRef are required, and (in some sense) reduces signature bloat.

Copy link
Member

@ecraig12345 ecraig12345 Jul 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, if you merge/rebase this, the function moved to src/git/gitUtilities.ts.

const ref = fromRef && toRef ? `${fromRef}..${toRef}` : "HEAD";
const results = git(["rev-list", ref, filename], { cwd });

if (results.success) {
return results.stdout.trim().split("\n").slice(-1)[0];
Expand Down