Workflow improvements and Docker Compose integration #12
Conversation
Introduces Docker Compose setup, startup, and teardown steps to the maven-publish GitHub Actions workflow. This allows test services defined in docker/test-services.yml to be started before publishing and stopped after, improving the workflow's environment setup.
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
|
🤖 Augment PR SummarySummary: Updates the Maven publish workflow to reflect Spring Data Redis 3.x/JDK 17 publishing and to manage required test services via Docker Compose. 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| - name: Docker Setup Compose | ||
| uses: docker/setup-compose-action@v1.2.0 | ||
| with: | ||
| version: latest |
There was a problem hiding this comment.
Using version: latest for Docker Compose can make the workflow non-reproducible (a future Compose release could break this job). Consider pinning to a known-good Compose version to reduce CI flakiness.
🤖 Was this useful? React with 👍 or 👎
| cache: maven | ||
|
|
||
| - name: Run Docker Compose | ||
| run: docker compose -f "docker/test-services.yml" up -d |
There was a problem hiding this comment.
docker compose up -d returns once containers are started, not necessarily when services are ready; if Maven runs integration tests immediately after, this can introduce flaky failures. Consider ensuring the test services are healthy/ready before mvn deploy proceeds.
🤖 Was this useful? React with 👍 or 👎
|
|
||
| - name: Stop Docker Compose | ||
| if: always() | ||
| run: docker compose -f "docker/test-services.yml" down |
There was a problem hiding this comment.
Because this step runs with if: always(), a failure in docker compose ... down would fail the whole job even if publishing succeeded, which can be surprising. Consider making teardown best-effort so cleanup issues don’t mask the real outcome.
🤖 Was this useful? React with 👍 or 👎
This pull request updates the
.github/workflows/maven-publish.ymlworkflow to improve the publishing process for Spring Data Redis 3.x projects and to integrate Docker Compose for managing test services during the build. The main changes focus on updating workflow descriptions and adding steps to set up, run, and clean up Docker Compose services.Workflow improvements and Docker Compose integration:
docker/setup-compose-action@v1.2.0GitHub Action.docker compose -f "docker/test-services.yml" up -d).docker compose -f "docker/test-services.yml" down).