fix the hour and minute units #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brohirrim
reviewed
Apr 5, 2025
| hour_unit = get_unit_allocation( custom_time_format, 'H' ); | ||
|
|
||
| minute_format = get_unit_allocation( custom_time_format, 'M' ); | ||
| local custom_time_format_without_hour_instruction = custom_time_format:gsub( "{$H" .. tostring(hour_unit) .. "}", "$H" ); |
There was a problem hiding this comment.
Is it possible to use removeInstructions here? or is format different
Author
There was a problem hiding this comment.
here you need to just remove hour instruction so minute instruction may be red out from the string
original code does not take multiple instructions into consideration thats why I only removed hour instructions here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the logic around time unit of hours and minutes
with this fix, it is possible to count over 23 hours and/or 59 minutes