Skip to content

Conversation

@Joeavaikath
Copy link
Contributor

@Joeavaikath Joeavaikath commented Jul 3, 2025

  • Add support for nonadmin backup delete

  • Works by manually editing the nab spec to set the DeleteBackup field to true

  • Add Makefile

This was linked to issues Jul 3, 2025
@Joeavaikath Joeavaikath requested a review from kaovilai July 3, 2025 18:59
@Joeavaikath Joeavaikath moved this to In Progress in oadp-cli v0.1 Jul 3, 2025
@Joeavaikath Joeavaikath self-assigned this Jul 3, 2025
@Joeavaikath Joeavaikath moved this from In Progress to PR Status in oadp-cli v0.1 Jul 3, 2025
@kaovilai kaovilai requested a review from Copilot July 6, 2025 04:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces CLI support for deleting non-admin backups, replaces the installation script with a Makefile, and updates documentation accordingly.

  • Adds a delete command under cmd/non-admin/backup to mark backups for deletion.
  • Introduces a Makefile for build, test, and install workflows and removes the old quick-create.sh.
  • Updates README to use Makefile targets and removes the design document.

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
quick-create.sh Removed quick installation script in favor of Makefile.
kubectl-oadp-design.md Removed outdated design document.
cmd/non-admin/backup/nonadminbackup_builder.go Added getCurrentNamespace helper for namespace detection.
cmd/non-admin/backup/delete.go Implemented delete command to set DeleteBackup field.
cmd/non-admin/backup/create.go Removed duplicate getCurrentNamespace definition.
cmd/non-admin/backup/backup.go Enabled delete subcommand and cleaned up command list.
README.md Updated installation and development workflow to use Makefile.
Makefile Added build, install, test, status, clean targets.
Comments suppressed due to low confidence (2)

cmd/non-admin/backup/backup.go:33

  • [nitpick] The commented-out commands block clutters the code; consider removing unused commented lines or extracting them into documentation for clarity.
	c.AddCommand(

cmd/non-admin/backup/delete.go:1

  • New delete functionality should be covered by unit or integration tests—consider adding tests for DeleteOptions.Run and deleteBackup.
package backup

Copy link
Contributor

@NicholasYancey NicholasYancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make file and delete.go looks good to merge.

@Joeavaikath Joeavaikath requested a review from kaovilai July 7, 2025 14:35
@kaovilai kaovilai closed this Jul 7, 2025
@github-project-automation github-project-automation bot moved this from Active PRs to Done in oadp-cli v0.1 Jul 7, 2025
@kaovilai kaovilai reopened this Jul 7, 2025
@kaovilai kaovilai merged commit a6714cc into main Jul 7, 2025
4 checks passed
@Joeavaikath Joeavaikath deleted the nab-delete branch July 23, 2025 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Create MAKEFILE non-admin backup delete

4 participants