-
Notifications
You must be signed in to change notification settings - Fork 11
Add nonadmin backup delete cli support #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces CLI support for deleting non-admin backups, replaces the installation script with a Makefile, and updates documentation accordingly.
- Adds a
deletecommand undercmd/non-admin/backupto mark backups for deletion. - Introduces a Makefile for build, test, and install workflows and removes the old
quick-create.sh. - Updates README to use Makefile targets and removes the design document.
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| quick-create.sh | Removed quick installation script in favor of Makefile. |
| kubectl-oadp-design.md | Removed outdated design document. |
| cmd/non-admin/backup/nonadminbackup_builder.go | Added getCurrentNamespace helper for namespace detection. |
| cmd/non-admin/backup/delete.go | Implemented delete command to set DeleteBackup field. |
| cmd/non-admin/backup/create.go | Removed duplicate getCurrentNamespace definition. |
| cmd/non-admin/backup/backup.go | Enabled delete subcommand and cleaned up command list. |
| README.md | Updated installation and development workflow to use Makefile. |
| Makefile | Added build, install, test, status, clean targets. |
Comments suppressed due to low confidence (2)
cmd/non-admin/backup/backup.go:33
- [nitpick] The commented-out commands block clutters the code; consider removing unused commented lines or extracting them into documentation for clarity.
c.AddCommand(
cmd/non-admin/backup/delete.go:1
- New delete functionality should be covered by unit or integration tests—consider adding tests for
DeleteOptions.RunanddeleteBackup.
package backup
NicholasYancey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make file and delete.go looks good to merge.
Add support for nonadmin backup delete
Works by manually editing the nab spec to set the
DeleteBackupfield to trueAdd Makefile