Skip to content

Comments

Create immediate mode for Editor prompt#271

Open
kurtbuilds wants to merge 1 commit intomikaelmello:mainfrom
kurtbuilds:main
Open

Create immediate mode for Editor prompt#271
kurtbuilds wants to merge 1 commit intomikaelmello:mainfrom
kurtbuilds:main

Conversation

@kurtbuilds
Copy link

@kurtbuilds kurtbuilds commented Sep 15, 2024

Using a tool like git, there is an "immediate" mode for the commit message, where running git commit immediately opens up the editor, without displaying a prompt, it aborts if the editor quits without saving, and then it displays the message.

Right now, prompt only works with the intermediary step of pressing e to open the editor.

This adds another function prompt_immediate() for users that want functionality more similar to how git commit works.

@lorenzleutgeb
Copy link

lorenzleutgeb commented Jul 15, 2025

I did not review this PR, but would like to use the same functionality. This PR looks stale. Is there anything I can do help it progress?

@kurtbuilds
Copy link
Author

kurtbuilds commented Jul 15, 2025

@mikaelmello any thoughts? it looks like this repo isn't receiving love lately (failing tests + last commit 6 months ago). let me know if there's a way to help.

lorenzleutgeb added a commit to radicle-dev/heartwood that referenced this pull request Jul 16, 2025
@lorenzleutgeb
term: Use inquire for spawning the editor
d81c2c3 
`radicle-term` includes quite a lot of rather "low-level" logic to spawn
the preferred editor of the user. In particular, this logic is
platform-dependent and only works on Unix-like platforms.

Also, `radicle-term` already depends on `inquire` which features an
editor prompt. It is a cross-platform solution to spawn the editor.
This commit changes the implementation of `Editor` to be a wrapper of
`inquire::Editor`, keeping the interface mostly intact.

Downsides:
 - We cannot edit a file "in place" this way, instead we have to read
   it, as `inquire` only supports editing temporary files. This can also
   be viewed as a benefit, as we lessen the risk of corruption of these
   files.
 - `inquire::Editor` contains borrows, so it is quite cumbersome to
   extend it with a custom mechanism for looking up the preferred
   editor. The lookup logic was kept, but needs to be invoked by the
   caller. In the future we might consider just using the logic provided
   by `inquire` or requesting a change to `inquire`.
 - The prompt is a bit strange. It does not show the current state of
   the output, see <mikaelmello/inquire#280>
   and <mikaelmello/inquire#271>.
lorenzleutgeb added a commit to radicle-dev/heartwood that referenced this pull request Jul 17, 2025
@lorenzleutgeb
term: Use inquire for spawning the editor
b07eea9 
`radicle-term` includes quite a lot of rather "low-level" logic to spawn
the preferred editor of the user. In particular, this logic is
platform-dependent and only works on Unix-like platforms.

Also, `radicle-term` already depends on `inquire` which features an
editor prompt. It is a cross-platform solution to spawn the editor.
This commit changes the implementation of `Editor` to be a wrapper of
`inquire::Editor`, keeping the interface mostly intact.

Downsides:
 - We cannot edit a file "in place" this way, instead we have to read
   it, as `inquire` only supports editing temporary files. This can also
   be viewed as a benefit, as we lessen the risk of corruption of these
   files.
 - `inquire::Editor` contains borrows, so it is quite cumbersome to
   extend it with a custom mechanism for looking up the preferred
   editor. The lookup logic was kept, but needs to be invoked by the
   caller. In the future we might consider just using the logic provided
   by `inquire` or requesting a change to `inquire`.
 - The prompt is a bit strange. It does not show the current state of
   the output, see <mikaelmello/inquire#280>
   and <mikaelmello/inquire#271>.
lorenzleutgeb added a commit to radicle-dev/heartwood that referenced this pull request Jul 23, 2025
@lorenzleutgeb
term: Use inquire for spawning the editor
70fb0d3 
`radicle-term` includes quite a lot of rather "low-level" logic to spawn
the preferred editor of the user. In particular, this logic is
platform-dependent and only works on Unix-like platforms.

Also, `radicle-term` already depends on `inquire` which features an
editor prompt. It is a cross-platform solution to spawn the editor.
This commit changes the implementation of `Editor` to be a wrapper of
`inquire::Editor`, keeping the interface mostly intact.

Downsides:
 - We cannot edit a file "in place" this way, instead we have to read
   it, as `inquire` only supports editing temporary files. This can also
   be viewed as a benefit, as we lessen the risk of corruption of these
   files.
 - `inquire::Editor` contains borrows, so it is quite cumbersome to
   extend it with a custom mechanism for looking up the preferred
   editor. The lookup logic was kept, but needs to be invoked by the
   caller. In the future we might consider just using the logic provided
   by `inquire` or requesting a change to `inquire`.
 - The prompt is a bit strange. It does not show the current state of
   the output, see <mikaelmello/inquire#280>
   and <mikaelmello/inquire#271>.
lorenzleutgeb added a commit to radicle-dev/heartwood that referenced this pull request Sep 13, 2025
@lorenzleutgeb
term: Use inquire for spawning the editor
4d46bad 
`radicle-term` includes quite a lot of rather "low-level" logic to spawn
the preferred editor of the user. In particular, this logic is
platform-dependent and only works on Unix-like platforms.

Also, `radicle-term` already depends on `inquire` which features an
editor prompt. It is a cross-platform solution to spawn the editor.
This commit changes the implementation of `Editor` to be a wrapper of
`inquire::Editor`, keeping the interface mostly intact.

Downsides:
 - We cannot edit a file "in place" this way, instead we have to read
   it, as `inquire` only supports editing temporary files. This can also
   be viewed as a benefit, as we lessen the risk of corruption of these
   files.
 - `inquire::Editor` contains borrows, so it is quite cumbersome to
   extend it with a custom mechanism for looking up the preferred
   editor. The lookup logic was kept, but needs to be invoked by the
   caller. In the future we might consider just using the logic provided
   by `inquire` or requesting a change to `inquire`.
 - The prompt is a bit strange. It does not show the current state of
   the output, see <mikaelmello/inquire#280>
   and <mikaelmello/inquire#271>.
lorenzleutgeb added a commit to radicle-dev/heartwood that referenced this pull request Sep 21, 2025
@lorenzleutgeb
term: Use inquire for spawning the editor
3636a68 
`radicle-term` includes quite a lot of rather "low-level" logic to spawn
the preferred editor of the user. In particular, this logic is
platform-dependent and only works on Unix-like platforms.

Also, `radicle-term` already depends on `inquire` which features an
editor prompt. It is a cross-platform solution to spawn the editor.
This commit changes the implementation of `Editor` to be a wrapper of
`inquire::Editor`, keeping the interface mostly intact.

Downsides:
 - We cannot edit a file "in place" this way, instead we have to read
   it, as `inquire` only supports editing temporary files. This can also
   be viewed as a benefit, as we lessen the risk of corruption of these
   files.
 - `inquire::Editor` contains borrows, so it is quite cumbersome to
   extend it with a custom mechanism for looking up the preferred
   editor. The lookup logic was kept, but needs to be invoked by the
   caller. In the future we might consider just using the logic provided
   by `inquire` or requesting a change to `inquire`.
 - The prompt is a bit strange. It does not show the current state of
   the output, see <mikaelmello/inquire#280>
   and <mikaelmello/inquire#271>.
lorenzleutgeb added a commit to radicle-dev/heartwood that referenced this pull request Sep 24, 2025
@lorenzleutgeb
term: Use inquire for spawning the editor
9a8e16c 
`radicle-term` includes quite a lot of rather "low-level" logic to spawn
the preferred editor of the user. In particular, this logic is
platform-dependent and only works on Unix-like platforms.

Also, `radicle-term` already depends on `inquire` which features an
editor prompt. It is a cross-platform solution to spawn the editor.
This commit changes the implementation of `Editor` to be a wrapper of
`inquire::Editor`, keeping the interface mostly intact.

Downsides:
 - We cannot edit a file "in place" this way, instead we have to read
   it, as `inquire` only supports editing temporary files. This can also
   be viewed as a benefit, as we lessen the risk of corruption of these
   files.
 - `inquire::Editor` contains borrows, so it is quite cumbersome to
   extend it with a custom mechanism for looking up the preferred
   editor. The lookup logic was kept, but needs to be invoked by the
   caller. In the future we might consider just using the logic provided
   by `inquire` or requesting a change to `inquire`.
 - The prompt is a bit strange. It does not show the current state of
   the output, see <mikaelmello/inquire#280>
   and <mikaelmello/inquire#271>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kurtbuilds @lorenzleutgeb