Added fix to resolve datasource when A/B testing with a View Rendering#448
Open
lchiao wants to merge 1 commit intomikeedwards83:masterfrom
Open
Added fix to resolve datasource when A/B testing with a View Rendering#448lchiao wants to merge 1 commit intomikeedwards83:masterfrom
lchiao wants to merge 1 commit intomikeedwards83:masterfrom
Conversation
Collaborator
|
@mikeedwards83 looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix corrects the A/B testing in View Renderings.
There was a previous fix made for similar reports to A/B testing, but that only corrected the issue with Controller Renderings.
I encountered this issue as I have a custom object construction task to map a custom view model. I noticed that A/B testing worked fine when Controller Renderings were used, however they broke with View Renderings and the Item was null with GetItemByPathOptions of the datasource in ItemUri format
This should address #433