Upgraded all sitecore librray related to Sitecore 10.4#465
Upgraded all sitecore librray related to Sitecore 10.4#465girishsharma008 wants to merge 13 commits intomikeedwards83:masterfrom
Conversation
and handled exception for below error - Exception: System.NullReferenceException Message: Object reference not set to an instance of an object. Source: Sitecore.Kernel at Sitecore.Links.UrlBuilders.Helpers.ItemPathBuilder.GetRelativePath(Item item, SiteInfo site) at Sitecore.Links.UrlBuilders.Helpers.ItemPathBuilder.Build(Item item, SiteInfo site)
This reverts commit 04e94b0.
removed unwanted folders
|
@girishsharma008 do you have access to the github actions to update these for a 10.4 release? |
sorry I do not have any access. i have only sent PR so that owner's can merge if changes are ok. |
|
@girishsharma008 The PR is missing changes in the Github workflow(s), probably should include that as well. |
@robmaas Thank you for letting me know i have done needful and pushed latest code |
|
|
||
| public static string GetItemUrl(Item item, UrlOptions urlOptions) | ||
| { | ||
| //Added check for when rendering paramater request comes as Sitecore.Links.UrlBuilders.Helpers.ItemPathBuilder.GetRelativePath |
There was a problem hiding this comment.
Seems like a better backward compatible fix is to copy out the previous null check based on the notes from #463
| Assert.True(true); | ||
| } | ||
| #endif | ||
| #if SC103 |
There was a problem hiding this comment.
| #if SC103 | |
| #if SC104 | |
(also wrong on rule 79, should be #if SC103 there)
4 participants
Upgraded all sitecore librray related to Sitecore 10.4
and handled exception for below error -
Exception: System.NullReferenceException
Message: Object reference not set to an instance of an object. Source: Sitecore.Kernel
at Sitecore.Links.UrlBuilders.Helpers.ItemPathBuilder.GetRelativePath(Item item, SiteInfo site) at Sitecore.Links.UrlBuilders.Helpers.ItemPathBuilder.Build(Item item, SiteInfo site)