Hide Gizmo, Grid, and Pivot Controls in Screenshots + HDRI and Controls Update#10
Open
notharshprajapati wants to merge 12 commits intomainfrom
Open
Hide Gizmo, Grid, and Pivot Controls in Screenshots + HDRI and Controls Update#10notharshprajapati wants to merge 12 commits intomainfrom
notharshprajapati wants to merge 12 commits intomainfrom
Conversation
hidden gizmo, Grid and piviot controls for Screenshot, updated HDRI to one shared, changed TransformControls to PivotControls
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
notharshprajapati
force-pushed
the
feature-ui-upgrades
branch
from
b5456c2 to
9da6d5c
Compare
notharshprajapati
force-pushed
the
feature-ui-upgrades
branch
from
e48d6ae to
6f7f3b1
Compare
mikejernil
reviewed
Dec 6, 2024
mikejernil
requested changes
Dec 6, 2024
src/App.tsx
Outdated
| const [sampleFileView, setSampleFileView] = useState(false); | ||
|
|
||
| const [models, setModels] = useState< | ||
| { |
Owner
There was a problem hiding this comment.
you can make this as a 'Model' type and declare it before using, as a type or interface
src/App.tsx
Outdated
| placeholder="Place Url..." | ||
| value={url} | ||
| onChange={(e) => setUrl(e.target.value)} | ||
| <div className="relative w-screen h-screen"> |
Owner
There was a problem hiding this comment.
See if this left panel code can be seperated into another file, like LoadUI, or UIPanel, so the App.jsx is not too cluttered
src/App.tsx
Outdated
| } | ||
|
|
||
| export default App; | ||
| // Add this function component at the top or in a separate file |
Owner
There was a problem hiding this comment.
shift this fn while seperating the panel code into a new file
| @@ -94,32 +98,31 @@ function Box() { | |||
| // FBX Model component | |||
| function FbxModel({ url }: { url: string }) { | |||
Owner
There was a problem hiding this comment.
See if FbxModel,ObjModel & GlbModel could be converted into a JSX fn
…r supported formats
Co-authored-by: Michael Jernil <43872457+mikejernil@users.noreply.github.com>
…nd optimize screenshot functionality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• Screenshot Update: Gizmo, Grid, and Pivot controls are now hidden during screenshots.
• HDRI Update: Switched to a shared HDRI.
• Controls Update: Replaced TransformControls with PivotControls for easier object manipulation.