Restructure, clean house, use docker, use dotenv...#1
Open
rm-rf-etc wants to merge 25 commits intomikicoding:masterfrom
Open
Restructure, clean house, use docker, use dotenv...#1rm-rf-etc wants to merge 25 commits intomikicoding:masterfrom
rm-rf-etc wants to merge 25 commits intomikicoding:masterfrom
Conversation
…const/let, replace vars with consts, etc. Add useBasicAuth to make it actually work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found and fixed various issues, also moved ENV vars to dotenv, which also works with docker-compose. Added a docker-compose.yml so people don't have to manually configure ArangoDB. Also helps if people want to deploy to Kubernetes.
You can safely use const and let now, no need to use var anymore.
I removed any comments which didn't clarify anything that wasn't already apparent in the code.
BTW, I notice you didn't include a call to
db.useBasicAuth(user, pass); I have to assume you are/were running ArangoDB with user auth disabled. This is not recommended, and will trip up some people who are trying out ArangoDB for the first time, by default it's enabled, so Unauthorized errors will come back in the response with no clear indication why.The way you were forming queries would leave you open to parameter injection. By changing the strings to
aqlstring templates, this is guarded against.