Open
Conversation
miniBill
requested changes
Jun 25, 2021
Owner
miniBill
left a comment
miniBill
left a comment
There was a problem hiding this comment.
In general, this PR makes sense
| import Element.WithContext.Internal as Internal exposing (Attr(..), Element(..), run, runAttr) | ||
|
|
||
|
|
||
| unwrap = |
Comment on lines
+195
to
+196
| type alias Placeholder context msg = | ||
| InputInternal.Placeholder context msg |
Owner
There was a problem hiding this comment.
Why are you doing this? [not saying it's wrong, just curious about the reason]
| = Option (context -> Input.Option value msg) | ||
|
|
||
|
|
||
| runOption : a -> Option a value msg -> Input.Option value msg |
Owner
There was a problem hiding this comment.
Sorry to be nitpicky, but can you s/a/context/
| @@ -0,0 +1,103 @@ | |||
| module Element.WithContext.Embed exposing | |||
Owner
There was a problem hiding this comment.
Not sure if it's better to call it Embed or Interop? Probably Embed is better
| @@ -1,5 +1,5 @@ | |||
| module Element.WithContext exposing | |||
| ( with, withAttribute, withDecoration, layout, layoutWith, element, attribute, attr, embed, embedAttr | |||
| ( with, withAttribute, withDecoration, layout, layoutWith, element, attribute, attr | |||
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #8 based on the embed-api branch by @miniBill
It exposes the 'run' functions directly in addition to the embed functions to deal with corner cases (mainly, having 2 different 'msg' types).