Server class tests #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zargess
force-pushed
the
dev/zargess/server-tests
branch
from
7bd86b5 to
cb7c198
Compare
Zargess
force-pushed
the
dev/zargess/server-tests
branch
from
cb7c198 to
1095490
Compare
Changes introduced to make the Server class more testable ## IsRunningStrategy Interfaces renamed to make it more general, to be used by both Worker and Server. It is also moved out of the worker package to make it for more general use. ### CheckFieldServerRunningStrategy Made a strategy for the Server class that checks the Server#isRunning method to return if the server is running. ## Server Socket Made the main method give ServerSocket to the start method of Server to make it easier to test. ## Storing threads As the Server creates several threads during execution, fields have been created to store these threads, to check if they were created. Could later be used to clean up running threads before the Fagi Server stops.
The worker threads, created by the Server, was not set as daemons, meaning they would survive the closure of the fagi server. This is now fixed, such that the threads are set as daemons.
## Testing the Server class The Server class is now tested with 100% test coverage. ### Issues PI test is flaky around setDaemon(true) on threads. This will be ignored for now. ## Moved utility function The Server class had a utility function to find public ip v4. This has been moved to a utility class in shared. ## RunOnceStrategy The implementation of IsRunningStrategy that runs once in tests has been renamed from WorkerRunOnceStrategy to RunOnceStrategy. This has been done as tests of the Server class now also utilises it. ## Data Made it possible to get the value of nextConversationId to help test loading of Conversations when starting the Server. ## PI test configuration Upgraded junit5PluginVersion from 1.2.1 to 1.2.2
Zargess
force-pushed
the
dev/zargess/server-tests
branch
from
1095490 to
f4a4741
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server
Testability
Made the Server class more testable by storing created worker threads, and made it possible to extract worker threads as well as ConversationHandler and ConversationHandler thread.
Daemons
Made created worker threads into daemons to make sure they are stopped when the main thread of the Fagi Server is stopped.
Testing the Server class
The Server class is now tested with 100% test coverage.
Issues
PI test is flaky around setDaemon(true) on threads. This will be ignored for now.
Data
Made it possible to get the value of nextConversationId to help test loading of Conversations when starting the Server.
PI test configuration
Upgraded junit5PluginVersion from 1.2.1 to 1.2.2