bazel: Parse workspace_log during query#2
Open
minor-fixes wants to merge 3 commits intobazel_workspace_log_protofrom
Open
bazel: Parse workspace_log during query#2minor-fixes wants to merge 3 commits intobazel_workspace_log_protofrom
minor-fixes wants to merge 3 commits intobazel_workspace_log_protofrom
Conversation
2f1a4a9 to
864baf8
Compare
9c190fb to
f7318d4
Compare
864baf8 to
afbc14a
Compare
f7318d4 to
b785e2a
Compare
This change modifies Query to return a struct of query results. These results include targets that match the query, as well as other optional information. The first useful such piece of information is the workspace log, which details when: * WORKSPACE caused a download to happen, including the SHA256 of the download * WORKSPACE caused a command execution to happen among other events. These events will be useful in reducing external dependencies down to the SHA256s of their corresponding downloads, rather than needing to resort to hashing individual files of the external dependencies.
9404e57 to
96177c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change modifies Query to return a struct of query results. These
results include targets that match the query, as well as other optional
information. The first useful such piece of information is the workspace
log, which details when:
download
among other events.
These events will be useful in reducing external dependencies down to
the SHA256s of their corresponding downloads, rather than needing to
resort to hashing individual files of the external dependencies.