Skip to content

Conversation

@Jeremy-Boyle
Copy link

@Jeremy-Boyle Jeremy-Boyle commented Feb 24, 2025

  • Fixed issues when importing the library due to types not being allowed in exports.
  • Removed copying the @types dir and moved it to DTS with vite.
  • Automated exports for the module, that way you can actually use the exported functions.

Related: #76

@Jeremy-Boyle Jeremy-Boyle changed the base branch from main to typescript February 24, 2025 17:20
@Jeremy-Boyle
Copy link
Author

Jeremy-Boyle commented Feb 26, 2025

Updates have been pushed please take a look

Also looks like miragejs uses rollup, so this looks good to me now

@jneurock
Copy link
Collaborator

Thanks @Jeremy-Boyle! I really appreciate the help with TypeScript.

@jneurock
Copy link
Collaborator

Had some issues with GitHub actions. Could you rebase your changes on the latest commit to the TypeScript branch?

@Jeremy-Boyle
Copy link
Author

Had some issues with GitHub actions. Could you rebase your changes on the latest commit to the TypeScript branch?

Should be good now

@jneurock jneurock merged commit e02792c into miragejs:typescript Feb 27, 2025
1 check passed
@Jeremy-Boyle Jeremy-Boyle deleted the improve/typescript branch February 28, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants