fix: --fix mode now fixes all files, not just the first#6
Merged
Conversation
any() short-circuits on the first True, so fix_file was never called on files after the first one that needed fixing. Use a list comprehension to force evaluation of all files.
mit-d
force-pushed
the
fix/fix-all-files
branch
from
5019f08 to
65d829e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
any(fix_file(f) for f in files)short-circuits on the firstTrue, so only the first fixable file was actually fixed per run. In a pre-commit context (where all staged files are passed at once), this meant only one file got fixed per commit attempt.fix_file()calls to execute before checking results.Test plan
test_fix_multiple_files_all_fixedverifies both files are fixed in a single--fixrun