Skip to content

refactor: extract duplicated company formatting to shared utility #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mitoperni merged 2 commits into from
Feb 9, 2026
Merged

refactor: extract duplicated company formatting to shared utility #60

mitoperni merged 2 commits into from
Feb 9, 2026

Conversation

@mitoperni
Copy link
Owner

@mitoperni mitoperni commented Feb 9, 2026 •
edited by devin-ai-integration bot
Loading

Description

Move duplicated company truncation logic from NetworkCard and StationsHeader into a reusable formatCompanies() function in utils.ts.

Type of Change

  • New feature
  • Bug fix
  • Refactoring
  • Documentation
  • Styling

Changes Made

  • src/lib/utils.ts: Add formatCompanies() utility that returns { text, remainingCount }
  • src/components/networks/network-card.tsx: Replace inline company logic with formatCompanies()
  • src/components/stations/stations-header.tsx: Replace inline company logic with formatCompanies()
  • src/lib/tests/utils.test.ts: Add 5 test cases for the new utility

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • No TypeScript errors
  • Tests added/updated
  • All CI checks pass

Related Issues

N/A

Open with Devin

@mitoperni
refactor: extract shared company formatting logic to utility
aabcaf6 
Move duplicated company truncation logic from NetworkCard and
StationsHeader into a reusable formatCompanies() function in utils.ts.
Add unit tests for edge cases.
@vercel
Copy link

vercel bot commented Feb 9, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cyclemap Ready Ready Preview, Comment Feb 9, 2026 10:14pm

devin-ai-integration[bot]
devin-ai-integration bot reviewed Feb 9, 2026
View reviewed changes
Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@mitoperni mitoperni self-assigned this Feb 9, 2026
@mitoperni mitoperni merged commit c475011 into main Feb 9, 2026
6 checks passed
@mitoperni mitoperni deleted the fix/extract-visible-companies branch February 10, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

Assignees

@mitoperni mitoperni

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mitoperni