Conversation
charleshu-8
commented
Aug 17, 2023
charleshu-8
commented
- Add support for an hdf2html convert command to generate HTML exports via HTML export feature from HDF Converters
Signed-off-by: Charles Hu <chu@mitre.org>
Signed-off-by: Charles Hu <chu@mitre.org>
Signed-off-by: Charles Hu <chu@mitre.org>
|
Kudos, SonarCloud Quality Gate passed!
|
|
Amndeep7
added
the
ready-to-merge
Amndeep7
left a comment
Amndeep7
left a comment
There was a problem hiding this comment.
Needs tests (here and in hdf-converters), needs to be documented in the readme
Amndeep7
removed
the
ready-to-merge
|
|
Needs comments added in README |
src/commands/convert/hdf2html.ts
Outdated
| files.push({data, fileName, fileID}) | ||
| } | ||
|
|
||
| const converter = await new Mapper(files, FileExportTypes.Administrator).toHTML('/html/') |
There was a problem hiding this comment.
Why not add an input flag for report type rather than defaulting to Administrator?
tailwind.config.js
Outdated
| @@ -0,0 +1,31 @@ | |||
| /** @type {import('tailwindcss').Config} */ | |||
There was a problem hiding this comment.
HDF to HTML has been refactored to avoid needing tailwind on SAF CLI. Tailwind is all managed by hdf-converters's build system.
Signed-off-by: kemley76 <kemley@mitre.org> Signed-off-by: kemley76 <kemley@mitre.org>
Signed-off-by: kemley76 <kemley@mitre.org>
Signed-off-by: kemley76 <kemley@mitre.org> Signed-off-by: kemley76 <kemley@mitre.org>
|
|
These changes are dependent on this Heimdall PR |
Signed-off-by: Kaden Emley <kemley@mitre.org>
Signed-off-by: Kaden Emley <kemley@mitre.org>
|
Now dependent on only this heimdall PR |
Signed-off-by: Kaden Emley <kemley@mitre.org>
|
|
This pull request has a conflict. Could you fix it @charleshu-8? |
4 participants
