Include child properties in Mesh::to_string() output #1811
+20
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the
Mesh::to_string()method to include a string representation of the mesh's children properties, such as the BSDF. This provide more comprehensive information when inspecting mesh objects.Shapes like
mi.Diskandmi.Rectangleinclude information about their children (e.g. BSDF) in their string representation by callingget_children_string(). However,mi.Meshand by extension its subclasses likemi.OBJMeshandmi.Cubedidn't include this information in theirto_string()output.Testing
The existing Python tests in
src/render/tests/test_mesh.pyhave been updated to account for the modified output of theto_string()method. These tests now validate that the child properties are correctly included in the string representation of the mesh.Checklist
cuda_*andllvm_*variants. If you can't test this, please leave below