Flavor Stash / Notes by daviddyess · Pull Request #75 · mixnjuice/frontend

daviddyess · 2020-05-15T04:36:04Z

User's Flavor Stash, with editors for min/max percentage and notes. Each flavor gets a single note, which utilizes markdown for rich text.

… added FlavorStash/Note component

# Conflicts: # src/reducers/flavor.js # src/reducers/flavor.test.js # src/reducers/index.js # src/sagas/flavor.js # src/sagas/flavor.test.js # src/sagas/index.js

…n, update; refactored note saga to delete a note with text set null (empty note)

…stash ui improvements

…shot

codecov · 2020-05-15T04:55:52Z

Codecov Report

Merging #75 (74a7a79) into master (abfb892) will decrease coverage by 2.43%.
The diff coverage is 59.89%.

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   83.19%   80.75%   -2.44%     
==========================================
  Files          88       92       +4     
  Lines        1660     1850     +190     
==========================================
+ Hits         1381     1494     +113     
- Misses        279      356      +77

Impacted Files	Coverage Δ
src/components/FlavorStash/Note.js	`0.00% <0.00%> (ø)`
src/reducers/index.js	`40.00% <ø> (ø)`
src/sagas/index.js	`100.00% <ø> (ø)`
src/pages/user/FlavorStash.js	`50.00% <42.55%> (-50.00%)`	⬇️
src/sagas/note.js	`80.23% <80.23%> (ø)`
src/reducers/note.js	`100.00% <100.00%> (ø)`
src/selectors/note.js	`100.00% <100.00%> (ø)`
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abfb892...74a7a79. Read the comment docs.

ayan4m1 · 2020-06-06T19:03:23Z

src/components/FlavorStash/Note.js

+    super(props);
+
+    this.state = {
+      editingNote: false,


Could just be editing

ayan4m1 · 2020-06-06T19:03:57Z

src/components/FlavorStash/Note.js

+    );
+  }
+
+  handleNoteEditor() {


Maybe handleToggleEditing?

ayan4m1 · 2020-06-06T19:04:57Z

src/components/FlavorStash/Note.js

+    } else {
+      actions.createNote(values);
+    }
+    this.setState({ updatedNote: note || '' });


Why are we copying the note to local component state?

It's mostly for user experience: it makes the update instant instead of having to pull it back from the API. But it also prevents the need for another GET request.

I've refactored this, when you create or update a note it updates the collection in the reducer

ayan4m1 · 2020-06-06T19:05:56Z

src/components/FlavorStash/Note.js

+                <Col md="12">
+                  {
+                    /* eslint-disable-next-line no-sync */
+                    unified()


My two cents, this shouldn't be done synchronously or inline. Maybe use an async function that updates local component state with the parsed result?

I haven't been able to get this to work with async. I also haven't been able to find an async example, they all show using this method

ayan4m1 · 2020-06-06T19:06:34Z

src/components/FlavorStash/Note.js

+                  </Button>
+                  <Button
+                    onClick={e => this.handleNoteEditor(false, e)}
+                    className="button-animation button--cancel"


This is likely something for a different pr, but I think this class name should be button--animated

ayan4m1 · 2020-06-06T19:07:32Z

src/components/FlavorStash/Note.js

+            <Fragment>
+              {
+                /* eslint-disable-next-line no-sync */
+                unified()


Same thing here with the inline/sync parsing.

ayan4m1 · 2020-06-06T19:07:51Z

src/components/FlavorStash/Note.js

+export const mapDispatchToProps = dispatch => ({
+  actions: bindActionCreators(
+    {
+      ...noteActions


No need to spread if it's the only action group being used.

Also fixed in the page as well.

ayan4m1 · 2020-06-06T19:08:37Z

src/components/FlavorStash/Note.test.js

+    expect(tree).toMatchSnapshot();
+  });
+
+  it('calls requestStash on mount', () => {


Should be requestNote right?

ayan4m1 · 2020-06-06T19:09:36Z

src/pages/user/FlavorStash.js

+  date(d) {
+    const s = new Date(d);
+
+    return s.toLocaleDateString();


Use date-fns format for this - docs

This seems to be something we should probably work on and integrate later. date-fns doesn't seem to be flexible enough to be used within the scope of this PR.

ayan4m1 · 2020-06-06T19:12:13Z

src/pages/user/FlavorStash.js

+      editingStash: false,
+      removed: {},
+      usage: {},
+      viewingNote: {}


This doesn't seem to be used, is it leftover?

ayan4m1 · 2020-06-06T19:13:02Z

src/pages/user/FlavorStash.js

+                        </InputGroup.Text>
+                      </InputGroup.Prepend>
+                      <Form.Control {...input} type="number" step="0.1" />
+                      <InputGroup.Text id="inputGroupAppend">%</InputGroup.Text>


Shouldn't need the id= attribute here.

ayan4m1 · 2020-06-06T19:13:14Z

src/pages/user/FlavorStash.js

+                  <Form.Group as={Col}>
+                    <InputGroup>
+                      <InputGroup.Prepend>
+                        <InputGroup.Text id="inputGroupPrepend">


Shouldn't need the id= attribute here or above.

# Conflicts: # src/pages/user/FlavorStash.js

ayan4m1 · 2020-11-18T01:17:34Z

src/components/FlavorStash/Note.js

+                </Col>
+              </Form.Row>
+            ) : null}
+            <Field name="userId">


Can these fields be pulled at submit-time rather than populated as hidden fields now?

I removed them and added a commit, their values are pre-filled and submitted with the form. I mainly just had them there for readability in the generated page source.

# Conflicts: # src/pages/user/FlavorStash.js # src/pages/user/FlavorStash.test.js # src/pages/user/__snapshots__/FlavorStash.test.js.snap

daviddyess added 18 commits March 7, 2020 22:24

Added note and notes redux, added redux support to Flavor Stash page,…

6df805f

… added FlavorStash/Note component

Flavor notes updates; reworking flavor stash layout

71097fc

Flavor notes updates

bd51382

Merge branch 'master' into feature/user/flavor-stash

0fbf7f0

# Conflicts: # src/reducers/flavor.js # src/reducers/flavor.test.js # src/reducers/index.js # src/sagas/flavor.js # src/sagas/flavor.test.js # src/sagas/index.js

Added ToggleButton to Flavor Stash

7d5d9a8

Merge branch 'master' into feature/user/flavor-stash

c51b41a

Updated icons; fixed an issue with state not updating on note creatio…

2efa9d1

…n, update; refactored note saga to delete a note with text set null (empty note)

Merge branch 'master' into feature/user/flavor-stash

00e083d

Added remark markdown support to flavor notes; made some small flavor…

e5b0343

…stash ui improvements

Don't display flavor note preview if the textarea is empty

23fe1d6

Improved FlavorStash styling and behavior

cd4ec7f

Updated FlavorStash Note component and tests

4646226

Updated FlavorStash page and tests

3e070b5

Added note, notes sagas to test

47e5380

Added note reducer test

5dacb30

'note redux updates and tests; removed notes` redux (unused)

c7407f4

Merge branch 'master-upstream' into feature/user/flavor-stash

c87f3b3

Fixed oddity with timezone differences throwing off dates in the snap…

c51306d

…shot

daviddyess requested a review from ayan4m1 May 15, 2020 17:51

ayan4m1 reviewed Jun 6, 2020

View reviewed changes

daviddyess added 7 commits August 29, 2020 14:01

Merge branch 'master' into feature/user/flavor-stash

356255c

# Conflicts: # src/pages/user/FlavorStash.js

Prettier updates

6a2cb18

Merge branch 'master' into feature/user/flavor-stash

ce93d6b

Removed boilerplate code

a9ab42b

Flavor Stash and Notes updates

f205a91

Updated all tests to reflect PR comment driven changes

3124d0d

Migrated FlavorStash and Note to functional components

3d4fb40

ayan4m1 reviewed Nov 18, 2020

View reviewed changes

daviddyess added 2 commits November 20, 2020 08:07

Removed unnecessary hidden fields in FlavorStash note form

532a8c9

Merge branch 'master' into test/merge/flavor-stash

74a7a79

# Conflicts: # src/pages/user/FlavorStash.js # src/pages/user/FlavorStash.test.js # src/pages/user/__snapshots__/FlavorStash.test.js.snap

Comments

Conversation

daviddyess commented May 15, 2020

Uh oh!

codecov bot commented May 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ayan4m1 Jun 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented May 15, 2020 •

edited

Loading

ayan4m1 Jun 6, 2020 •

edited

Loading