For #267. Add backup option for checking file access#268
Open
bschneidr wants to merge 1 commit intomllg:masterfrom
Open
For #267. Add backup option for checking file access#268bschneidr wants to merge 1 commit intomllg:masterfrom
bschneidr wants to merge 1 commit intomllg:masterfrom
Conversation
…ethod from 'R.utils::fileAccess()`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small PR uses a more robust method for checking whether a file can be read, addressing a longstanding problem with accessing files on network drives.
I think it would also be good to attribute this to @HenrikBengtsson, since the method is copied from the "R.utils" package he developed. Perhaps in the NEWS file or in the roxygen documentation? I'm not sure what would be most appropriate.