Improve makeXFunction variants (fixes #281, #283, #284)#285
Open
tdeenes wants to merge 3 commits intomllg:masterfrom
Open
Improve makeXFunction variants (fixes #281, #283, #284)#285tdeenes wants to merge 3 commits intomllg:masterfrom
makeXFunction variants (fixes #281, #283, #284)#285tdeenes wants to merge 3 commits intomllg:masterfrom
Conversation
This PR fixes several issues reported [here](mllg#281), [here](mllg#283), and [here](mllg#284). All these bugs are related to the `makeXFunction` variants, which share a lot of code and use the `parse(eval(...))` construct internally. This PR introduces: 1. A function factory for all three `makeXFunction` variants; 2. Uses R's metaprogramming capabilities to generate the functions without using `parse(eval(...))`; 3. Adds unit tests to cover the reported issues. Resolves mllg#281, resolves mllg#283, resolves mllg#284.
|
can you pull in the extra test case from my PR? 1685beb#diff-962d4bf4d8ba5fa037da8e6d5bdc3e7852eec1a74da2478472fed258030fcc73 EDIT: Running locally it does pass. |
Contributor
Author
|
Indeed, the unit test case I added is not that thorough as yours. I will update the PR soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes several issues reported here, here, and here.
All these bugs are related to the
makeXFunctionvariants, which share a lot of code and use theparse(eval(...))construct internally.This PR introduces:
makeXFunctionvariants;parse(eval(...));Resolves #281, resolves #283, resolves #284.