[SeaweedFS] Migrate from MinIO to SeaweedFS as the S3-compatible storage backend#245
Merged
shay79il merged 1 commit intomlrun:developmentfrom Feb 18, 2026
Merged
Conversation
shay79il
force-pushed
the
CEML-619-seaweedFS
branch
2 times, most recently
from
e08bcc4 to
28affeb
Compare
shay79il
force-pushed
the
CEML-619-seaweedFS
branch
3 times, most recently
from
9b76178 to
c67bbfc
Compare
shay79il
force-pushed
the
CEML-619-seaweedFS
branch
5 times, most recently
from
58082cb to
6054a07
Compare
shay79il
force-pushed
the
CEML-619-seaweedFS
branch
3 times, most recently
from
52230d8 to
453cb04
Compare
shay79il
force-pushed
the
CEML-619-seaweedFS
branch
3 times, most recently
from
d64c4b3 to
ce7fa8b
Compare
shay79il
force-pushed
the
CEML-619-seaweedFS
branch
from
7a25284 to
f3d7745
Compare
| */}} | ||
| {{- define "mlrun-ce.s3.validateConfig" -}} | ||
| {{- if not .Values.seaweedfs.enabled -}} | ||
| {{- fail "seaweedfs.enabled must be set to true for S3 storage backend." -}} |
Collaborator
There was a problem hiding this comment.
We should fail only if the user enable pipeline also beucase MLRun may store his files in other file storage, I prefer to add an info message that says - seaweedfs.enabled must be set to true when using pipelines for storing pipelines aritfacts
charts/mlrun-ce/values.yaml
Outdated
| # to access the S3-compatible storage backend (SeaweedFS) | ||
| # ============================================================================= | ||
| s3: | ||
| accessKey: "admin" |
Collaborator
There was a problem hiding this comment.
can we use the same creds we had before
minio/minio123?
shay79il
force-pushed
the
CEML-619-seaweedFS
branch
from
f3d7745 to
a65942d
Compare
shay79il
force-pushed
the
CEML-619-seaweedFS
branch
from
a65942d to
f020889
Compare
GiladShapira94
approved these changes
Feb 18, 2026
shay79il
force-pushed
the
CEML-619-seaweedFS
branch
from
f020889 to
a128281
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.