Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 43 additions & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,51 @@ jobs:
if [[ -n "$changed" ]]; then
echo "changed=true" >> "$GITHUB_OUTPUT"
fi
- name: Check version bump (handles rcN numerically)
if: steps.list-changed.outputs.changed == 'true'
run: |
TARGET_BRANCH=${{ github.event.repository.default_branch }}
OLD_VERSION=$(git show origin/$TARGET_BRANCH:charts/mlrun-ce/Chart.yaml | grep '^version:' | awk '{print $2}')
NEW_VERSION=$(grep '^version:' charts/mlrun-ce/Chart.yaml | awk '{print $2}')
echo "Old version: $OLD_VERSION"
echo "New version: $NEW_VERSION"

# Extract base version (before hyphen) and prerelease (after hyphen)
OLD_BASE=$(echo "$OLD_VERSION" | cut -d'-' -f1)
NEW_BASE=$(echo "$NEW_VERSION" | cut -d'-' -f1)
OLD_PRE=$(echo "$OLD_VERSION" | cut -d'-' -f2-)
NEW_PRE=$(echo "$NEW_VERSION" | cut -d'-' -f2-)

# If base version increased, that's a valid bump
if [[ "$NEW_BASE" > "$OLD_BASE" ]]; then
echo "✓ Base version bumped: $OLD_BASE -> $NEW_BASE"
exit 0
fi

# If releasing (removing prerelease), that's valid
if [[ "$NEW_VERSION" == "$NEW_BASE" && "$OLD_VERSION" != "$OLD_BASE" ]]; then
echo "✓ Released: $OLD_VERSION -> $NEW_VERSION"
exit 0
fi

# Extract numeric part from prerelease (rc9 -> 9, rc10 -> 10)
OLD_NUM=$(echo "$OLD_PRE" | sed 's/[^0-9]//g')
NEW_NUM=$(echo "$NEW_PRE" | sed 's/[^0-9]//g')

# Compare prerelease numbers numerically
if [[ -n "$NEW_NUM" && -n "$OLD_NUM" && "$NEW_NUM" -gt "$OLD_NUM" ]]; then
echo "✓ Prerelease bumped: $OLD_PRE -> $NEW_PRE"
exit 0
fi

echo "✖ Version not bumped! $OLD_VERSION -> $NEW_VERSION"
exit 1

- name: Run chart-testing (lint)
run: make helm-lint
if: steps.list-changed.outputs.changed == 'true'
run: |
helm lint charts/mlrun-ce
ct lint --target-branch ${{ github.event.repository.default_branch }} --check-version-increment=false
env:
HELM_LINT_DEFAULT_BRANCH: ${{ github.event.repository.default_branch }}

Expand Down
2 changes: 1 addition & 1 deletion charts/mlrun-ce/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v1
name: mlrun-ce
version: 0.11.0-rc9
version: 0.11.0-rc10
description: MLRun Open Source Stack
home: https://iguazio.com
icon: https://www.iguazio.com/wp-content/uploads/2019/10/Iguazio-Logo.png
Expand Down
11 changes: 9 additions & 2 deletions charts/mlrun-ce/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -606,10 +606,17 @@ kafka:
port: 9093
type: internal
tls: false
- name: internal
- name: external
port: 9094
type: internal
type: nodeport
tls: false
configuration:
bootstrap:
nodePort: 30094
# For external access, set advertisedHost per broker:
# brokers:
# - broker: 0
# advertisedHost: kafka.<namespace>.<system>.lab.iguazeng.com

storage:
type: persistent-claim
Expand Down
Loading