Open
Conversation
…g MegaCore pin definitions
…g MegaCore pin definitions
…/kizmit99/DirectIO into MegaCore_Atmega2561_1281_support
Author
|
Sorry - I'm confused right now... My pull request should have included only a single commit (adding one file and modifying one), but it seems to have 'pulled in' 3 additional commits that were not of my doing (believe they were commits in your project that were pulled into my fork). This is literally my first pull request using github, so apologies if I've screwed something up! |
Owner
|
That can happen with rebasing... the file changes look good. Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've modified your library to support the ATmega2561 and 1281 chips, with pinouts defined from the MCUdude/MegaCore project. I've tested the changes on a custom board using the ATmega1281 chip and as far as I can tell, they are working.
Thought I would offer these changes up to see if you were interested in including them.