Open
Conversation
Sanjeet990
approved these changes
Aug 13, 2021
|
Please merge this PR, it solve some bugs |
I hope the maintainer will find some time to merge this up. |
Owner
|
Hello @alirezaafkar, thank you for your contribution and sorry for being so late I will review you PR today evening 😊 |
mmoamenn
requested changes
May 16, 2022
|
|
||
| public class WheelItem { | ||
|
|
||
| public int id; |
Owner
There was a problem hiding this comment.
I see no reason to add a new id variable to the WheelItem
Check getAngleOfIndexTarget the calculations already depend on the index of the WheelItem so it's risky just to let the user set the id himself
|
@mmoamenn Can you please add a Function to set the Text Size? |
SheikhSaad
approved these changes
Feb 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed this issues:
#17
#26
#23