You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
moment-timezone is a huge library, adding about 800kb to the page. I think you can get a lot of the same functionality by either using Intl.DateTimeFormat, or potentially some features of date-fns, which is already a dependency.
Typo in PR title
I think the UI could use some improvements.
Do we need a convert button? I think you could do without it, but if you think we need it, have it follow the same style as the rest of the app.
Could we use a smart dropdown that allows search? We may have an example already, but at the very least, let's use the component <Dropdown />
Might be worth looking at UI's of other timezone converters to see if we can innovate here.
@shabbiryusufali I fixed the bundle size reporter and made it more useful, so it shows you a diff against main. Pull the latest changes before continuing working.
moment-timezone is a huge library, adding about 800kb to the page. I think you can get a lot of the same functionality by either using Intl.DateTimeFormat, or potentially some features of date-fns, which is already a dependency.
Typo in PR title
I think the UI could use some improvements.
Do we need a convert button? I think you could do without it, but if you think we need it, have it follow the same style as the rest of the app.
Could we use a smart dropdown that allows search? We may have an example already, but at the very least, let's use the component <Dropdown />
Might be worth looking at UI's of other timezone converters to see if we can innovate here.
Just crossing out completed suggestions/tasks to keep a track of this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR finishes the plan from Issue #20