Skip to content

fix: Fix Windows file read issue due to Unix permissions #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChineseAStar wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Fix Windows file read issue due to Unix permissions #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion dadb/src/main/kotlin/dadb/Dadb.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import dadb.forwarding.TcpForwarder
import java.io.File
import java.nio.file.Files
import okio.*
import java.nio.file.FileSystems

interface Dadb : AutoCloseable {

Expand Down Expand Up @@ -250,6 +251,10 @@ interface Dadb : AutoCloseable {

private const val MIN_EMULATOR_PORT = 5555
private const val MAX_EMULATOR_PORT = 5683
private const val DEFAULT_MODE = 0b110100100
private val isPosixFs: Boolean by lazy {
FileSystems.getDefault().supportedFileAttributeViews().contains("posix")
}

@JvmStatic
@JvmOverloads
Expand Down Expand Up @@ -310,7 +315,11 @@ interface Dadb : AutoCloseable {
}

private fun readMode(file: File): Int {
return Files.getAttribute(file.toPath(), "unix:mode") as? Int ?: throw RuntimeException("Unable to read file mode")
if (!isPosixFs) {
return DEFAULT_MODE
}
val mode = Files.getAttribute(file.toPath(), "unix:mode") as? Int
return mode ?: DEFAULT_MODE
}
}
}