Skip to content

Conversation

@0x0elliot
Copy link
Contributor

This PR is just to pass the DCO tests, so that we can swiftly get the PR merged. The original PR is here: #3222

store.GetTask() seems to have the nil pointer check in every other location we could find it to be used, so I'm sure this is just a small hiccup.

I don't really care if this PR is merged or if you clean it up on your side - the main thing is we need it fixed due to Swarm randomly crashing when you got hundreds of containers in many many services sending jobs back and forth. We have no clear way to reproduce it due to the goroutine madness.

Ref issue from first time it occurred: #3216

Signed-off-by: Aditya <60684641+0x0elliot@users.noreply.github.com>
@0x0elliot
Copy link
Contributor Author

Hey @tonistiigi, Please review this PR.

@0x0elliot
Copy link
Contributor Author

0x0elliot commented Nov 8, 2025

Thanks! Let me know if there are any other things left from my side to fulfil delaying the merge @tonistiigi :)

Do you have any idea why this issue might be popping up?

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 98d08be into moby:master Nov 10, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants