Open
Conversation
MichaelGrinstead
force-pushed
the
mg/marketplace
branch
from
8eb4be9 to
c25f2ca
Compare
moda-contracts/src/Marketplace.sol
Outdated
|
|
||
| uint256 totalPrice = sale.pricePerToken * tokenAmount; | ||
| uint256 fee = (treasuryFee * totalPrice) / 10_000; | ||
| IERC20(_usdc).safeTransferFrom(_msgSender(), address(this), totalPrice); |
Contributor
There was a problem hiding this comment.
we shouldn't have to cast _usdc. Let's just make it token.safeTransferFrom(...).
MichaelGrinstead
force-pushed
the
mg/marketplace
branch
2 times, most recently
from
6532db7 to
b4d6c6c
Compare
| address indexed releases, | ||
| uint256 indexed tokenId, | ||
| address indexed buyer, | ||
| address seller, |
Contributor
There was a problem hiding this comment.
This event definition is inconsistent with the actual one defined above
Contributor
There was a problem hiding this comment.
Let's check all event definitions ^
DoubleOTheven
requested changes
Jan 10, 2024
Contributor
DoubleOTheven
left a comment
DoubleOTheven
left a comment
There was a problem hiding this comment.
Pls update the events in the test to match the actual definitions
MichaelGrinstead
force-pushed
the
mg/marketplace
branch
from
b4d6c6c to
9e6b0d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #
Description