Move examples to server directory #198
Merged
+56
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will prepare for the client implementation in modelcontextprotocol#192
Nyholm
changed the title
Contributor
|
No that's fine. Thanks for the assist ❤️ |
Member
|
Test failure is real i'm afraid - namespaces in server.php files maybe? |
Contributor
Author
Yes, I move the bootstrap.php too. I see in #192, that the client is not using the bootstrap file. |
CodeWithKyrian
approved these changes
Dec 27, 2025
Contributor
Author
|
Wohoo. CI is green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prepare for the client implementation in #192
When reviewing #192, I thought I can make the diff smaller by moving the existing examples to
examples/serverdirectory (as suggested here).@CodeWithKyrian I hope you dont mind me helping out with this.