Add idle session timeout to StreamableHTTPSessionManager#2022
Open
felixweinberger wants to merge 1 commit intomainfrom
Open
Add idle session timeout to StreamableHTTPSessionManager#2022felixweinberger wants to merge 1 commit intomainfrom
felixweinberger wants to merge 1 commit intomainfrom
Conversation
9 tasks
Sessions created via StreamableHTTPSessionManager persist indefinitely in _server_instances even after the client disconnects, leaking memory over time. Add a session_idle_timeout parameter that automatically terminates and removes sessions that receive no HTTP requests for the configured duration. Each session manages its own lifetime via an anyio CancelScope deadline — no background reaper task needed. Incoming requests push the deadline forward to keep active sessions alive. Github-Issue: #1283
felixweinberger
force-pushed
the
fweinberger/idle-timeout-termination-main
branch
from
c8e7443 to
84ac697
Compare
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
1 similar comment
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #1994 (v1.x) to main.
Motivation and Context
Sessions created via StreamableHTTPSessionManager persist indefinitely in
_server_instanceseven after the client disconnects, leaking memory over time (issue #1283).The
session_idle_timeoutparameter automatically terminates and removes sessions that receive no HTTP requests for the configured duration. Each session manages its own lifetime via an anyioCancelScopedeadline — no background reaper task needed. Incoming requests push the deadline forward to keep active sessions alive.How Has This Been Tested?
11 dedicated tests covering: idle reaping, activity reset, multi-session independence, validation, terminate idempotency, lifecycle, and end-to-end behavior. Existing manager tests continue to pass.
Breaking Changes
None — new optional parameter with default
None.Types of changes
Checklist