fix: prevent stdio_server from closing process stdio handles #2040
+64
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #1933.
stdio_server()wrapssys.stdin.bufferandsys.stdout.bufferinTextIOWrapper. When the wrapper gets garbage-collected, it closes the underlying buffer, killing process stdio. Any subsequentprint()or stdin usage raisesValueError: I/O operation on closed file.os.dup()gives the wrapper its own copy of the file descriptor, so closing it doesn't affect the original process stdio.How Has This Been Tested?
stdio_server(), then asserts the original fds are still open viaos.fstat().Breaking Changes
No.
Types of changes
Checklist