Skip to content

Add optional description field to Implementation struct #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexhancock merged 2 commits into from
Feb 10, 2026
Merged

Add optional description field to Implementation struct #649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d2f864
feat: add optional description field to Implementation struct
DaleSeo Feb 9, 2026
99b684f
test: update snapshots
DaleSeo Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions crates/rmcp/src/model.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,6 +834,8 @@ pub struct Implementation {
pub title: Option<String>,
pub version: String,
#[serde(skip_serializing_if = "Option::is_none")]
pub description: Option<String>,
#[serde(skip_serializing_if = "Option::is_none")]
pub icons: Option<Vec<Icon>>,
#[serde(skip_serializing_if = "Option::is_none")]
pub website_url: Option<String>,
Expand All @@ -851,6 +853,7 @@ impl Implementation {
name: env!("CARGO_CRATE_NAME").to_owned(),
title: None,
version: env!("CARGO_PKG_VERSION").to_owned(),
description: None,
icons: None,
website_url: None,
}
Expand Down Expand Up @@ -2925,6 +2928,7 @@ mod tests {
name: "test-server".to_string(),
title: Some("Test Server".to_string()),
version: "1.0.0".to_string(),
description: Some("A test server for unit testing".to_string()),
icons: Some(vec![
Icon {
src: "https://example.com/icon.png".to_string(),
Expand All @@ -2942,6 +2946,7 @@ mod tests {

let json = serde_json::to_value(&implementation).unwrap();
assert_eq!(json["name"], "test-server");
assert_eq!(json["description"], "A test server for unit testing");
assert_eq!(json["websiteUrl"], "https://example.com");
assert!(json["icons"].is_array());
assert_eq!(json["icons"][0]["src"], "https://example.com/icon.png");
Expand All @@ -2961,6 +2966,7 @@ mod tests {
let implementation: Implementation = serde_json::from_value(old_json).unwrap();
assert_eq!(implementation.name, "legacy-server");
assert_eq!(implementation.version, "0.9.0");
assert_eq!(implementation.description, None);
assert_eq!(implementation.icons, None);
assert_eq!(implementation.website_url, None);
}
Expand All @@ -2974,6 +2980,7 @@ mod tests {
name: "icon-server".to_string(),
title: None,
version: "2.0.0".to_string(),
description: None,
icons: Some(vec![Icon {
src: "https://example.com/server.png".to_string(),
mime_type: Some("image/png".to_string()),
Expand Down
3 changes: 3 additions & 0 deletions crates/rmcp/tests/test_elicitation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1064,6 +1064,7 @@ async fn test_initialize_request_with_elicitation() {
name: "test-client".to_string(),
version: "1.0.0".to_string(),
title: None,
description: None,
website_url: None,
icons: None,
},
Expand Down Expand Up @@ -1109,6 +1110,7 @@ async fn test_capability_checking_logic() {
name: "test-client".to_string(),
version: "1.0.0".to_string(),
title: None,
description: None,
website_url: None,
icons: None,
},
Expand All @@ -1130,6 +1132,7 @@ async fn test_capability_checking_logic() {
name: "test-client".to_string(),
version: "1.0.0".to_string(),
title: None,
description: None,
website_url: None,
icons: None,
},
Expand Down
6 changes: 6 additions & 0 deletions crates/rmcp/tests/test_message_schema/client_json_rpc_message_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,6 +701,12 @@
"Implementation": {
"type": "object",
"properties": {
"description": {
"type": [
"string",
"null"
]
},
"icons": {
"type": [
"array",
Expand Down
6 changes: 6 additions & 0 deletions crates/rmcp/tests/test_message_schema/client_json_rpc_message_schema_current.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,6 +701,12 @@
"Implementation": {
"type": "object",
"properties": {
"description": {
"type": [
"string",
"null"
]
},
"icons": {
"type": [
"array",
Expand Down
6 changes: 6 additions & 0 deletions crates/rmcp/tests/test_message_schema/server_json_rpc_message_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -914,6 +914,12 @@
"Implementation": {
"type": "object",
"properties": {
"description": {
"type": [
"string",
"null"
]
},
"icons": {
"type": [
"array",
Expand Down
6 changes: 6 additions & 0 deletions crates/rmcp/tests/test_message_schema/server_json_rpc_message_schema_current.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -914,6 +914,12 @@
"Implementation": {
"type": "object",
"properties": {
"description": {
"type": [
"string",
"null"
]
},
"icons": {
"type": [
"array",
Expand Down
1 change: 1 addition & 0 deletions examples/clients/src/streamable_http.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ async fn main() -> Result<()> {
name: "test sse client".to_string(),
title: None,
version: "0.0.1".to_string(),
description: None,
website_url: None,
icons: None,
},
Expand Down