-
-
Notifications
You must be signed in to change notification settings - Fork 190
Add: T2A Crafting Gumps and Menus for Core Skills #2181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| /packages/* | ||
| /Distribution/Configuration/server-access.json | ||
|
|
||
| .fake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope that was a mistake cursor made when I was showing it which json to read from early on in the beginning and Its useless
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a complete T2A-style crafting menu system integrated with ModernUO’s crafting engine, ensuring non-invasive changes and backward compatibility with existing systems. Key changes include introducing new gump classes for crafting (e.g. T2ACraftGump, CartographyMenu, CarpentryMenu, BowFletchingMenu) and updating core crafting files (e.g. DefTinkering, DefTailoring, Resmelt, Repair, Enhance, CraftItem, CraftGump) to conditionally show T2A menus when appropriate.
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Projects/UOContent/Engines/Craft/T2A/T2ACraftGump.cs | Introduces the static T2ACraftSystem that routes crafting actions to the new T2A menus. |
| Projects/UOContent/Engines/Craft/T2A/CartographyMenu.cs | Implements a new crafting menu for cartography with custom item entries and messages. |
| Projects/UOContent/Engines/Craft/T2A/CarpentryMenu.cs | Adds a new menu for carpentry with separate sections (Chairs, Tables, Misc) and resource checks. |
| Projects/UOContent/Engines/Craft/T2A/BowFletchingMenu.cs | Provides a new menu for bow fletching including resource availability checks and response handling. |
| Projects/UOContent/Engines/Craft/DefTinkering.cs, DefTailoring.cs, etc. | Updates core crafting systems to use the T2A menus conditionally based on Core.Expansion. |
| Projects/UOContent/Engines/Craft/Core/* | Consistently replaces direct CraftGump calls with a ShowCraftMenu helper that routes to the appropriate menu. |
| Projects/Server/Menus/ItemListMenu.cs | Modifies ItemListEntry constructor to include craft index and adds a debug log for menu creation. |
Co-authored-by: Kamron Batman <3953314+kamronbatman@users.noreply.github.com>
Co-authored-by: Kamron Batman <3953314+kamronbatman@users.noreply.github.com>
cd1e99e to
88908e4
Compare
0abdf82 to
3cbfa2d
Compare
Summary
This pull request introduces a complete T2A-style crafting menu system integrated with ModernUO's crafting engine.
Changes
T2ACraftGump.cs: a custom retro-styled crafting gumpPurpose
Provides a Second Age crafting interface for shards targeting classic UO eras. These additions are non-invasive and fully compatible with existing systems.
Testing