Skip to content

Conversation

@Delphi79
Copy link

Summary

This pull request introduces a complete T2A-style crafting menu system integrated with ModernUO's crafting engine.

Changes

  • Added T2ACraftGump.cs: a custom retro-styled crafting gump
  • Added T2A crafting menus for:
    • Alchemy
    • Blacksmithing
    • BowFletching
    • Carpentry
    • Cartography
    • Inscription
    • Tailoring
    • Tinkering
  • Modified core files to support new gumps while maintaining backward compatibility

Purpose

Provides a Second Age crafting interface for shards targeting classic UO eras. These additions are non-invasive and fully compatible with existing systems.

Testing

  • All menus tested in-game
  • Verified crafting interactions with base tools and gump display
  • Changes don't break non-T2A menus

@kamronbatman kamronbatman requested a review from Copilot May 11, 2025 03:35
/packages/*
/Distribution/Configuration/server-access.json

.fake
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this?

Copy link
Author

@Delphi79 Delphi79 May 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope that was a mistake cursor made when I was showing it which json to read from early on in the beginning and Its useless

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a complete T2A-style crafting menu system integrated with ModernUO’s crafting engine, ensuring non-invasive changes and backward compatibility with existing systems. Key changes include introducing new gump classes for crafting (e.g. T2ACraftGump, CartographyMenu, CarpentryMenu, BowFletchingMenu) and updating core crafting files (e.g. DefTinkering, DefTailoring, Resmelt, Repair, Enhance, CraftItem, CraftGump) to conditionally show T2A menus when appropriate.

Reviewed Changes

Copilot reviewed 29 out of 29 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Projects/UOContent/Engines/Craft/T2A/T2ACraftGump.cs Introduces the static T2ACraftSystem that routes crafting actions to the new T2A menus.
Projects/UOContent/Engines/Craft/T2A/CartographyMenu.cs Implements a new crafting menu for cartography with custom item entries and messages.
Projects/UOContent/Engines/Craft/T2A/CarpentryMenu.cs Adds a new menu for carpentry with separate sections (Chairs, Tables, Misc) and resource checks.
Projects/UOContent/Engines/Craft/T2A/BowFletchingMenu.cs Provides a new menu for bow fletching including resource availability checks and response handling.
Projects/UOContent/Engines/Craft/DefTinkering.cs, DefTailoring.cs, etc. Updates core crafting systems to use the T2A menus conditionally based on Core.Expansion.
Projects/UOContent/Engines/Craft/Core/* Consistently replaces direct CraftGump calls with a ShowCraftMenu helper that routes to the appropriate menu.
Projects/Server/Menus/ItemListMenu.cs Modifies ItemListEntry constructor to include craft index and adds a debug log for menu creation.

Delphi79 and others added 3 commits May 10, 2025 23:42
Co-authored-by: Kamron Batman <3953314+kamronbatman@users.noreply.github.com>
Co-authored-by: Kamron Batman <3953314+kamronbatman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants