Update mailtrap.md #549
Update mailtrap.md #549
Conversation
We updated the Mailtrap product itself, and it's no longer a testing tool exclusively. This description is more accurate and still focuses on MODX's users' SMTP based email sending needs. Also updated 'smtp.mailtrap.io' to 'live.smtp.mailtrap.io'. Trying again after previous PR received a comment about being promotional. Removed any possible fluff.
|
You have removed the reason for mentioning the Mailtrap service in the MODX docs. I would start the page with the following text.
|
|
@Jako you're right, our mistake. I will attempt to edit the current submission and add some more detail about setup relevant to the users, based on Amazon SES' doc page on your site too since it also includes email sending. |
This description is more accurate considering that Mailtrap is no longer only a testing tool. Added email sending features and kept the testing features. Also went in more detail on how to set up both functions.
|
@Jako can you check now please? |
|
It looks ok, but I am not the one to decide this. I don't have merge access. |
|
@Jako gotcha! i'll wait then. thanks :) |
|
@Ibochkarev all done, i believe. |
|
@Ibochkarev hey. one question: is it possible to also update the page in the 3.x version? |
3 participants
We updated the Mailtrap product itself, and it's no longer a testing tool exclusively. This description is more accurate and still focuses on MODX's users' SMTP based email sending needs. Also updated 'smtp.mailtrap.io' to 'live.smtp.mailtrap.io'.
Trying again after previous PR received a comment about being promotional. Removed any possible fluff.
Description
What does this change, and why is the change needed?
Explained above.
Affected versions
Is the change relevant to 2.x, 3.x, or both?
Relevant issues
Please link to any relevant issues or pull requests.
#548