feat: add WithMaxSubscriptions config backed by stream vs unary grpc connection pools#450
Merged
feat: add WithMaxSubscriptions config backed by stream vs unary grpc connection pools#450
Conversation
malandis
reviewed
Jun 18, 2025
momento-sdk/src/main/java/momento/sdk/config/TopicConfiguration.java
Outdated
Show resolved
Hide resolved
momento-sdk/src/main/java/momento/sdk/StreamTopicGrpcConnectionPool.java
Outdated
Show resolved
Hide resolved
momento-sdk/src/main/java/momento/sdk/DynamicStreamGrpcConnectionPool.java
Show resolved
Hide resolved
malandis
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/momentohq/dev-eco-issue-tracker/issues/1164
Opted for minimal config changes to maintain backwards compatibility.
WithMaxSubscriptionsand anIsNumStreamChannelsDynamicflag to theTopicConfigurationAlso added more tests to the subscription initialization tests (part of the retry tests) to exercise the dynamic channel creation. The main difference between the static and dynamic pools are:
StaticStreamGrpcConnectionPooluses a regularjava.util.Listthat is initialized once in the constructor and is never modified.DynamicStreamGrpcConnectionPoolusesjava.util.concurrent.CopyOnWriteArrayListandAtomicIntegerto be able to dynamically add channels as needed up until the maximum number of channels has been reached.