feat: new credential provider methods for accepting global api keys#451
Merged
feat: new credential provider methods for accepting global api keys#451
Conversation
nand4011
reviewed
Dec 15, 2025
momento-sdk/src/main/java/momento/sdk/auth/StringCredentialProvider.java
Outdated
Show resolved
Hide resolved
momento-sdk/src/main/java/momento/sdk/auth/ApiKeyV2CredentialProvider.java
Outdated
Show resolved
Hide resolved
momento-sdk/src/main/java/momento/sdk/auth/ApiKeyV2CredentialProvider.java
Outdated
Show resolved
Hide resolved
momento-sdk/src/main/java/momento/sdk/auth/EnvVarV2CredentialProvider.java
Outdated
Show resolved
Hide resolved
anitarua
requested changes
Dec 15, 2025
momento-sdk/src/test/java/momento/sdk/auth/V2CredentialProviderTest.java
Outdated
Show resolved
Hide resolved
momento-sdk/src/test/java/momento/sdk/auth/V2CredentialProviderTest.java
Outdated
Show resolved
Hide resolved
momento-sdk/src/test/java/momento/sdk/auth/V2CredentialProviderTest.java
Outdated
Show resolved
Hide resolved
momento-sdk/src/test/java/momento/sdk/auth/StringCredentialProviderTest.java
Outdated
Show resolved
Hide resolved
momento-sdk/src/main/java/momento/sdk/auth/ApiKeyV2CredentialProvider.java
Outdated
Show resolved
Hide resolved
nand4011
reviewed
Dec 16, 2025
| super(getApiKeyValueFromEnvVar(apiKeyEnvVar), getEndpointValueFromEnvVar(endpointEnvVar)); | ||
| } | ||
|
|
||
| private static String getApiKeyValueFromEnvVar(String apiKeyEnvVar) { |
Contributor
There was a problem hiding this comment.
I still think we should make a single general function for this instead of having two slightly different ones. It could be used in the legacy env var provider as well.
nand4011
approved these changes
Dec 16, 2025
Contributor
nand4011
left a comment
nand4011
left a comment
There was a problem hiding this comment.
LGTM. I don't want to block on simplifying the env var loading functions.
anitarua
approved these changes
Dec 16, 2025
Contributor
anitarua
left a comment
anitarua
left a comment
There was a problem hiding this comment.
can fast follow with some refactoring along with examples updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes momentohq/dev-eco-issue-tracker#1269